Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Wikipedia:Contents pages + added color to Current Events + a few lint errors I made #192

Closed
wants to merge 1 commit into from

Conversation

saya-rbt
Copy link
Contributor

This is a continuation of #191. It has been merged, but quickly after, I realized that the Contents pages were also broken, so I went ahead and fixed them.

I also used it to add some color to the Current Events titles, to make them easier to distinguish and the page overall more pleasant to read. (@the-j0k3r this is for you 😛)

Lastly, when running npm test, I realized there were a few lint errors I made that got merged upstream, so I fixed my mistakes and included them in this commit as well.

Please let me know what you think!

@the-j0k3r
Copy link
Member

the-j0k3r commented Nov 10, 2021

Problem is that you are ignoring the colors.

What is blue by default should remain blue and what is green should remain green and so on. This includes the backgrounds not just the headers.

So now what was blue is now green what was green bg is all gray and nothing matches the default styling.

However since no one if fixing the issues I will accept anything that is not bright colors even if its against everything we worked so hard to get at.

So thanks anyway.

@saya-rbt
Copy link
Contributor Author

Ah I see, sorry about that.

It's fine, I'll fix it in the next few days again, no worries!

Sorry for not getting it earlier, I'll do it properly this time, just give me some time as I am quite busy these days :)

@the-j0k3r
Copy link
Member

Sorry for not getting it earlier, I'll do it properly this time, just give me some time as I am quite busy these days :)

Thanks and dont worry about it, it was just loud noises from the time I spent countless hours time fixing this.
Im glad someone even cares to fix it no matter what.

Thanks again.

@AfroThundr3007730
Copy link
Member

Sorry for not getting it earlier, I'll do it properly this time, just give me some time as I am quite busy these days :)

Thanks and dont worry about it, it was just loud noises from the time I spent countless hours time fixing this. Im glad someone even cares to fix it no matter what.

Thanks again.

I've been super busy these days, but I'm still watching this repo. I'll fix any breaking changes as I find them. Thanks for keeping up with the reviews though.

@AfroThundr3007730
Copy link
Member

@saya-rbt Were you still planning to update the color selections? We can merge it once that's done.

@saya-rbt
Copy link
Contributor Author

@AfroThundr3007730 yes, I would like to do so. I'm sorry I haven't been able to do so before, I've been really busy these days.

Depending on my current workload, I might be able to do it tomorrow or on Saturday. I should be able to be done within the next week ultimately, but this is a very temporary ETA as my workload is quite unpredictable.

If you're fine with me getting done with it around next week, I'll do it. Otherwise, if you would like to merge these (unfinished) changes, please go ahead.

@AfroThundr3007730
Copy link
Member

That's cool, no rush here.

@saya-rbt saya-rbt closed this by deleting the head repository Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants