Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portuguese Wikipedia doesn't have all it's pages in dark-mode #140

Open
requeijaum opened this issue Aug 30, 2020 · 8 comments
Open

Portuguese Wikipedia doesn't have all it's pages in dark-mode #140

requeijaum opened this issue Aug 30, 2020 · 8 comments
Labels

Comments

@requeijaum
Copy link

image

@the-j0k3r
Copy link
Member

Thanks , clearly they have updated their CSS also.

Will fix asap.

@the-j0k3r
Copy link
Member

This is a huge job, most of the site is broken, main page aside which is fixed locally is only the tip of the iceberg.

The top link of that page for Arte etc all broken and other many such pages.

So really this bug report is going to take a while to complete.

@requeijaum
Copy link
Author

Wow. Thanks for the feedback, though.

@the-j0k3r
Copy link
Member

the page you linked looks like

Screenshot_2020-09-01 Wikipédia, a enciclopédia livre

A few other pages fixe, many to go before its done.

the-j0k3r added a commit that referenced this issue Sep 2, 2020
main page + some other urls fixed, many to go

help welcome.
the-j0k3r added a commit that referenced this issue Sep 2, 2020
* portuguese site fixes re: #140 (the-j0k3r)
* devdeps update (the-j0k3r)
@the-j0k3r
Copy link
Member

@requeijaum upgrade to 3.4.17 includes the fixes for page you reported + a few others pt pages fixed.

See 76573c5 if interested.

Pending more time to do more fixes to close this, ATM too many pt pages still broken to get anywhere to closing this.

Help welcome in form of PRs into the PT @moz-document section

@the-j0k3r the-j0k3r changed the title Portuguese Wikipedia doesn't have all it's front-page in dark-mode Portuguese Wikipedia doesn't have all it's pages in dark-mode Sep 3, 2020
@maaldheefee
Copy link

This is not just about Portuguese wiki. Portuguese Wikipedia among a few others is an early adopter of the upcoming update to the default Vector skin. Registered users can enable it for all languages within their user preferences, by disabling "Use Legacy Vector" option in Appearance tab.

https://www.mediawiki.org/wiki/Reading/Web/Desktop_Improvements

https://diff.wikimedia.org/2020/09/23/wikipedia-is-getting-a-new-look-for-the-first-time-in-10-years-heres-why

Here's how English Wikipedia looks like in latest version of Vector.

image

@the-j0k3r
Copy link
Member

the-j0k3r commented Sep 25, 2020

We only support he default vector theme see https://github.com/StylishThemes/Wikipedia-Dark#limitations

If this becomes default will have to consider what updates it will take to fix this.

Also real life is taking my time to look more into this, Also dont have an account.

PR's welcome though. ;)

@Mottie maybe has some thoughts to share.

the-j0k3r added a commit that referenced this issue Oct 16, 2020
the-j0k3r added a commit that referenced this issue Oct 16, 2020
* fixes re: #140 (the-j0k3r)
* style odd table bg fixes #148 (the-j0k3r)
@the-j0k3r
Copy link
Member

Please read #151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants