Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start to GitHub Material Theme #568

Closed
wants to merge 1 commit into from

Conversation

sparcut
Copy link
Contributor

@sparcut sparcut commented Nov 30, 2017

Regarding #522

This is a start to the GitHub Material theme, works fine in the few languages I'd tried it in. However in others does not match at all - e.g. go between the GitHub and CodeMirror in CSS.

So this is not complete, but if anyone wants to pick it up, it should be pretty simple to complete.

@sparcut sparcut changed the title Added Material Theme Start to GitHub Material Theme Nov 30, 2017
@unigazer unigazer mentioned this pull request Dec 17, 2017
3 tasks
@the-j0k3r

This comment has been minimized.

@scote
Copy link

scote commented Jan 31, 2019

Any update on this theme?

@silverwind
Copy link
Member

Complete color matching between different syntax engines is not a requirement (as it is not possible). Source files should be split in three parts, themes/src/{github,codemirror,jupyter}.css. Jupyter theme is also missing.

So in summary, no, this is not quite ready yet.

the-j0k3r referenced this pull request Mar 3, 2019
In default style this is.`.bg-purple` and is `!important;` so we need to manually override this.
@silverwind
Copy link
Member

No movement here since quite some time, if someone wants to continue this, raise a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ⭐ New feature or request help wanted 🙏 Extra attention is needed themes 🖼️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants