Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR]: Remove orphaned without moving to orphaned_dir #590

Closed
2 tasks
ScaredyCatX opened this issue Jun 18, 2024 · 2 comments · Fixed by #602
Closed
2 tasks

[FR]: Remove orphaned without moving to orphaned_dir #590

ScaredyCatX opened this issue Jun 18, 2024 · 2 comments · Fixed by #602
Assignees
@bobokun
Labels
feature request New feature or request status:added-to-develop Feature Request or Bug Fix is in Develop

Comments

@ScaredyCatX
Copy link

Is your feature request related to a problem? Please elaborate.

As of now, when removing orphaned torrents, qbm first moves the files to orphaned_dir then delete them based on empty_after_x_days. The moving process isn't necessary when the value is 0, which cause high IO when moving files between drives just to delete them afterwards

Describe the solution you'd like

My suggestion is to add an if statement to check if the value of empty_after_x_days=0, if it is, then skip the whole moving process and just delete the files.

Does your solution involve any of the following?

  • New config option
  • New command option

Describe alternatives you've considered

I created 3 qbm config files:

  1. Deals with tagging, share limits, and clearing torrents (basically, everything other than removing orphaned)
  2. Only remove orphaned option is enabled with the orphaned_dir located on the SSD
  3. same as 2 but with the orphaned_dir located on the HDD

Who will this benefit?

Anyone with multiple drives who's not using unRAID, especially for racing.

Additional Information

No response
@ScaredyCatX ScaredyCatX added the feature request New feature or request label Jun 18, 2024
bobokun added a commit that referenced this issue Jul 1, 2024
@ineednewpajamas @bobokun
Fix min_seeding_time tag removal when max_seeding_time is -1 (#598)
2b547d6 
* Update share_limits.py to fix #590

---------

Co-authored-by: bobokun <12660469+bobokun@users.noreply.github.com>
bobokun added a commit that referenced this issue Jul 1, 2024
@bobokun
Fixes [FR]: Remove orphaned without moving to orphaned_dir #590
3ff636b
@bobokun bobokun added the status:added-to-develop Feature Request or Bug Fix is in Develop label Jul 1, 2024
@bobokun
Copy link
Collaborator

bobokun commented Jul 1, 2024

This has been added to develop. Please test and let me know if you run into any issues. Thanks!

@ScaredyCatX
Copy link
Author

ScaredyCatX commented Jul 2, 2024 •
edited
Loading

I have just tested it, all good, It deletes orphaned immediately as expected. Thanks

@bobokun bobokun mentioned this issue Jul 5, 2024
Merged
@bobokun bobokun closed this as completed in 4e08f62 Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bobokun bobokun

Labels
feature request New feature or request status:added-to-develop Feature Request or Bug Fix is in Develop
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

4.1.7 StuffAnThings/qbit_manage
2 participants
@bobokun @ScaredyCatX