Adding setCookies option to a page instance #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abrom
requested changes
Apr 24, 2020
There was a problem hiding this comment.
Thanks @Richacinas good idea. There are a few things that I think will need to be addressed though. I've left comments, but let me know if you have any questions.
Co-Authored-By: Andrew Bromwich <a.bromwich@gmail.com>
|
Updated Readme.md |
abrom
requested changes
Apr 24, 2020
abrom
approved these changes
Apr 24, 2020
There was a problem hiding this comment.
Nice one @Richacinas 👍
In the future I would also ask that you add spec tests to validate what you're adding works the way it is supposed to. That way there is less likely to be bugs or regressions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi added the possibility to add cookies.