-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement 145 change reviews block according to fsd #177
Enhancement 145 change reviews block according to fsd #177
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Про закомментированные строки не оч понял. Что с ними?
@@ -1,11 +1,12 @@ | |||
import { FC } from 'react' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import { FC } from 'react' | |
import { type FC } from 'react' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
а почему такой синтаксис? в чем разница между просто FC и type FC (я такого не видела, поэтому спрашиваю)
@@ -30,7 +31,7 @@ const ReviewsBlock: FC<Props> = props => { | |||
<article className={styles.header}> | |||
<Heading type={HeadingType.NORMAL}> | |||
{title} | |||
<img src={IconHand} alt=""></img> | |||
<img src={IconHand} alt="иконка"></img> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<img src={IconHand} alt="иконка"></img> | |
<img src={IconHand} alt="иконка" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Вроде все отлично, только разберись с комментариями
Добавить storybook для компонентов |
No description provided.