Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IsValueGetter is false for Nullables #132

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

Romanx
Copy link
Contributor

@Romanx Romanx commented Aug 16, 2022

This is because nullable is technically a struct (which is a value type) but is able to have no value for its inner and so be 'null

fixes #116

This is because nullable is technically a struct (which is a value type) but is able to have no value for its inner and so be 'null
@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #132 (3e62679) into master (d8462ea) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 3e62679 differs from pull request most recent head d19603c. Consider uploading reports for the commit d19603c to get more accurate results

@@           Coverage Diff           @@
##           master     #132   +/-   ##
=======================================
  Coverage   93.06%   93.06%           
=======================================
  Files          76       76           
  Lines        2121     2121           
  Branches      380      380           
=======================================
  Hits         1974     1974           
  Misses         77       77           
  Partials       70       70           
Impacted Files Coverage Δ
...rc/Stubble.Compilation/Contexts/CompilerContext.cs 97.08% <100.00%> (ø)
...erers/TokenRenderers/InterpolationTokenRenderer.cs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Romanx Romanx merged commit c92acb1 into master Aug 17, 2022
@Romanx Romanx deleted the feature/compilation-nullable-ints branch August 17, 2022 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiled renderer evaluating int? truthy value incorrectly
1 participant