Feature/KITOSUDV-3812 #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrjsawdk
reviewed
Jan 13, 2023
There was a problem hiding this comment.
@a-naskret Looks great.
- Some adjustments to doc
- Some comments around structure
Core.DomainServices/Repositories/Reference/IReferenceRepository.cs
Outdated
Show resolved
Hide resolved
Core.DomainServices/Repositories/Reference/ReferenceRepository.cs
Outdated
Show resolved
Hide resolved
Infrastructure.DataAccess/Migrations/202301120832587_added_uuid_to_external_reference.cs
Show resolved
Hide resolved
.../V2/External/DataProcessingRegistrations/Mapping/DataProcessingRegistrationResponseMapper.cs
Outdated
Show resolved
Hide resolved
…s/kitos into feature/KITOSUDV-3812
mrjsawdk
reviewed
Jan 14, 2023
Tests.Unit.Presentation.Web/Models/V2/DataProcessingRegistrationResponseMapperTest.cs
Outdated
Show resolved
Hide resolved
mrjsawdk
reviewed
Jan 14, 2023
Tests.Unit.Presentation.Web/Models/V2/ExternalReferenceResponseMapperTest.cs
Outdated
Show resolved
Hide resolved
mrjsawdk
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KITOS Pull request template
The following procedure dictates the steps needed before a Pull request can be merged into master.
Implement:
All requirements are implemented and unit tests are green
Merge master into branch / rebase with master:
Make sure you are testing your changes and how they co-exist with the latest version of master
Green on integration:
All integration tests are green on integration
Request review:
Tag whomever you wish to review your code
Review completed:
Reviewer ticks this box when review comments have been submitted
Changes:
PR owner and reviewer agrees on which changes must be made and the changes are committed.
Merge master into branch / rebase with master:
Make sure you are testing your changes and how they co-exist with the latest version of master
Green on integration:
All integration tests are green on integration