v8 Upgrade Handler #683
Merged
v8 Upgrade Handler #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampocs
commented
Mar 23, 2023
shellvish
approved these changes
Mar 24, 2023
app/upgrades/v8/upgrades.go
Outdated
|
|
||
| // Add the evmos airdrop | ||
| ctx.Logger().Info("Adding evmos airdrop...") | ||
| blockTime := uint64(ctx.BlockTime().Unix()) |
There was a problem hiding this comment.
we should pick a blocktime in the future I think
There was a problem hiding this comment.
good call! should we shoot for next monday?
app/upgrades/v8/upgrades_test.go
Outdated
|
|
||
| // Check that the params of the evmos airdrop were initialized | ||
| s.Require().Equal(v8.EvmosAirdropIdentifier, evmosAirdrop.AirdropIdentifier, "evmos airdrop identifier") | ||
| s.Require().Zero(evmosAirdrop.ClaimedSoFar.Int64(), "cevmos laimed so far") |
There was a problem hiding this comment.
nit, "evmos claimed so far"
sampocs
added
A:automerge
sontrinh16
pushed a commit
to notional-labs/stride
that referenced
this pull request
Mar 27, 2023
Co-authored-by: vish-stride <vishal@stridelabs.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
Context and purpose of the change
Upgrade handler for v8
Brief Changelog
Author's Checklist
I have...
If skipped any of the tests above, explain.
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
Documentation and Release Note
Unreleasedsection inCHANGELOG.md?How is the feature or change documented?
XXXx/<module>/spec/)