Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Docker Image on New Release (Pt. 2) #671

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Conversation

sampocs
Copy link
Collaborator

@sampocs sampocs commented Mar 15, 2023

Closes: #XXX

Context and purpose of the change

Final change needed for the release image to build as it's not possible to fully test the GH action until it has been merged into main first

Brief Changelog

  • Enabled docker buildkit in GH action so image build's successfully

Author's Checklist

I have...

  • Run and PASSED locally all GAIA integration tests
  • If the change is contentful, I either:
    • Added a new unit test OR
    • Added test cases to existing unit tests
  • OR this change is a trivial rework / code cleanup without any test coverage

If skipped any of the tests above, explain.

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • reviewed state machine logic
  • reviewed API design and naming
  • manually tested (if applicable)
  • confirmed the author wrote unit tests for new logic
  • reviewed documentation exists and is accurate

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md?
  • This pull request updates existing proto field values (and require a backend and frontend migration)?
  • Does this pull request change existing proto field names (and require a frontend migration)?
    How is the feature or change documented?
    • not applicable
    • jira ticket XXX
    • specification (x/<module>/spec/)
    • README.md
    • not documented

@sampocs sampocs requested a review from a team March 15, 2023 03:02
@github-actions github-actions bot added the T:CI label Mar 15, 2023
@shellvish shellvish self-requested a review March 15, 2023 03:02
@riley-stride riley-stride self-requested a review March 15, 2023 03:02
@asalzmann asalzmann self-requested a review March 15, 2023 03:02
Copy link
Contributor

@shellvish shellvish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing

@sampocs sampocs merged commit 4febc23 into main Mar 22, 2023
sontrinh16 pushed a commit to notional-labs/stride that referenced this pull request Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants