Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go relayer & integration test timing #668

Merged
merged 4 commits into from
Apr 6, 2023
Merged

Conversation

sampocs
Copy link
Collaborator

@sampocs sampocs commented Mar 14, 2023

Closes: #XXX

Brief Changelog

  • Updated go relayer and moved coin type to relayer config
  • Made the sleep timing in the integration tests for dynamic for liquid stake

Author's Checklist

I have...

  • Run and PASSED locally all GAIA integration tests
  • If the change is contentful, I either:
    • Added a new unit test OR
    • Added test cases to existing unit tests
  • OR this change is a trivial rework / code cleanup without any test coverage

If skipped any of the tests above, explain.

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • reviewed state machine logic
  • reviewed API design and naming
  • manually tested (if applicable)
  • confirmed the author wrote unit tests for new logic
  • reviewed documentation exists and is accurate

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md?
  • This pull request updates existing proto field values (and require a backend and frontend migration)?
  • Does this pull request change existing proto field names (and require a frontend migration)?
    How is the feature or change documented?
    • not applicable
    • jira ticket XXX
    • specification (x/<module>/spec/)
    • README.md
    • not documented

@sampocs sampocs requested a review from a team March 14, 2023 16:55
@shellvish shellvish self-requested a review March 14, 2023 16:55
@asalzmann asalzmann self-requested a review March 14, 2023 16:55
@riley-stride riley-stride self-requested a review March 14, 2023 16:55
@sampocs sampocs changed the title Changed sleep command in LS integration tests Update go relayer & integration test timing Mar 14, 2023
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you!

@github-actions github-actions bot added the Stale label Mar 29, 2023
@sampocs
Copy link
Collaborator Author

sampocs commented Mar 29, 2023

Open

@github-actions github-actions bot removed the Stale label Mar 30, 2023
Copy link
Contributor

@shellvish shellvish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@sampocs sampocs merged commit edeffb3 into main Apr 6, 2023
@faddat faddat mentioned this pull request May 8, 2023
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants