Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epoch Logs Cleanup - Day Epoch Pt. 2 #518

Merged
merged 9 commits into from
Dec 17, 2022
Merged

Conversation

sampocs
Copy link
Collaborator

@sampocs sampocs commented Dec 15, 2022

Closes: #XXX

Context and purpose of the change

Continuing the epoch log cleanup in an effort to make the logs more digestible. This PR addresses the remaing day epoch logs. I'll follow up with the callback logs in a separate PR.

Brief Changelog

  • Cleaned up logs for InitiateHostZoneUnbondings
  • Fixed logging for sdk.Int types (switched from %d to %v)
  • Campfire rule - misc cleanup/standardization across functions (e.g. variable naming)

Author's Checklist

I have...

  • Run and PASSED locally all GAIA integration tests
  • If the change is contentful, I either:
    • Added a new unit test OR
    • Added test cases to existing unit tests
  • OR this change is a trivial rework / code cleanup without any test coverage

If skipped any of the tests above, explain.

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • reviewed state machine logic
  • reviewed API design and naming
  • manually tested (if applicable)
  • confirmed the author wrote unit tests for new logic
  • reviewed documentation exists and is accurate

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md?
  • This pull request updates existing proto field values (and require a backend and frontend migration)?
  • Does this pull request change existing proto field names (and require a frontend migration)?
    How is the feature or change documented?
    • not applicable
    • jira ticket XXX
    • specification (x/<module>/spec/)
    • README.md
    • not documented

@sampocs sampocs marked this pull request as ready for review December 15, 2022 19:18
@sampocs sampocs requested a review from a team December 15, 2022 20:29
@sampocs sampocs added the v5 label Dec 15, 2022
Copy link
Contributor

@asalzmann asalzmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! mind running the integration tests, because lots of core logic was touched?

x/stakeibc/keeper/update_redemption_rates_test.go Outdated Show resolved Hide resolved
x/stakeibc/keeper/validator_selection.go Show resolved Hide resolved
x/stakeibc/keeper/unbonding_records.go Outdated Show resolved Hide resolved
@sampocs
Copy link
Collaborator Author

sampocs commented Dec 16, 2022

lgtm! mind running the integration tests, because lots of core logic was touched?

Yup, ran em all already (i've just been using the checkbox in the readme)

@sampocs sampocs merged commit d1938b9 into main Dec 17, 2022
sontrinh16 pushed a commit to notional-labs/stride that referenced this pull request Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants