Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ledger support #263

Merged
merged 1 commit into from
Sep 3, 2022
Merged

Add Ledger support #263

merged 1 commit into from
Sep 3, 2022

Conversation

dylanschultzie
Copy link
Contributor

Signed-off-by: Dylan Schultz hello@schultzie.dev

Closes: #XXX

Context and purpose of the change

Brief Changelog

Author's Checklist

I have...

  • Run and PASSED locally all GAIA integration tests
  • If the change is contentful, I either:
    • Added a new unit test OR
    • Added test cases to existing unit tests
  • OR this change is a trivial rework / code cleanup without any test coverage

If skipped any of the tests above, explain.

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • reviewed state machine logic
  • reviewed API design and naming
  • manually tested (if applicable)
  • confirmed the author wrote unit tests for new logic
  • reviewed documentation exists and is accurate

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md?
  • This pull request updates existing proto field values (and require a backend and frontend migration)?
  • Does this pull request change existing proto field names (and require a frontend migration)?
    How is the feature or change documented?
    • not applicable
    • jira ticket XXX
    • specification (x/<module>/spec/)
    • README.md
    • not documented

Signed-off-by: Dylan Schultz <hello@schultzie.dev>
Copy link
Contributor

@asalzmann asalzmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for adding this!

@dylanschultzie
Copy link
Contributor Author

@asalzmann I'm not sure what the labeler check is, can you help me debug? Presumably because I haven't added a label, but also, I can't.

@asalzmann
Copy link
Contributor

asalzmann commented Sep 3, 2022

Ah, yeah this is an annoying bug. The labeler action scans the changes and adds labels accordingly (using a project secret with write permissions). However, it doesn't work if you're merging in from a fork! actions/labeler#12

Going to merge

@asalzmann asalzmann merged commit 579ec77 into Stride-Labs:main Sep 3, 2022
riley-stride pushed a commit that referenced this pull request Sep 5, 2022
sontrinh16 pushed a commit to notional-labs/stride that referenced this pull request Mar 27, 2023
Signed-off-by: Dylan Schultz <hello@schultzie.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants