Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the C++ dependency list to look for SCons instead of GNU Make. The process for doing this is a little different from Make, since it's usually a Python package.
Changes Made
make
from the list of C++ dependencies to check for, addedscons
scons
dependency check and call to look for the executable first, defaulting to the Python package if not foundCSolver
constructor to referencescons
instead ofmake
Testing
Run
test_check_cpp_support
unit test in test_check_cpp_support.py or any explicit C++ solver test with:python3 -m pip install scons
(should build and run successfully)Fixes #923