Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSACSolver simulates the telegraph model incorrectly #918

Merged
merged 8 commits into from
Feb 9, 2023
Merged

SSACSolver simulates the telegraph model incorrectly #918

merged 8 commits into from
Feb 9, 2023

Conversation

briandrawert
Copy link
Member

No description provided.

@briandrawert briandrawert added the bug Something isn't working label Jan 21, 2023
@briandrawert briandrawert added this to the 1.8.0 Release milestone Jan 21, 2023
@briandrawert briandrawert self-assigned this Jan 21, 2023
@briandrawert briandrawert linked an issue Jan 21, 2023 that may be closed by this pull request
SSACSolver simulates the telegraph model incorrectly #917
Closed
@briandrawert briandrawert changed the base branch from main to develop January 21, 2023 21:08
@briandrawert briandrawert marked this pull request as draft January 21, 2023 21:09
@briandrawert briandrawert marked this pull request as ready for review January 24, 2023 22:20
BryanRumsey
BryanRumsey requested changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@BryanRumsey BryanRumsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test notebook fails to run and should be moved to the Advanced_Features directory

@briandrawert
Copy link
Member Author

briandrawert commented Jan 31, 2023 •
edited
Loading

TODO: move telegraph model into example_models, make unit test, delete notebook
-Done

@BryanRumsey BryanRumsey mentioned this pull request Feb 9, 2023
Merged
@mdip226 mdip226 merged commit 97f0116 into develop Feb 9, 2023
@mdip226 mdip226 deleted the 917-ssacsolver-simulates-the-telegraph-model-incorrectly branch February 9, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdip226 mdip226 mdip226 approved these changes

@BryanRumsey BryanRumsey BryanRumsey approved these changes

@seanebum seanebum seanebum approved these changes

@kevinsanft kevinsanft Awaiting requested review from kevinsanft

Assignees

@briandrawert briandrawert

Labels
bug Something isn't working
Projects
None yet
Milestone
1.8.0 Release
Development

Successfully merging this pull request may close these issues.

SSACSolver simulates the telegraph model incorrectly
4 participants
@briandrawert @seanebum @BryanRumsey @mdip226