Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General add method for model #764

Merged
merged 24 commits into from
Apr 11, 2022
Merged

General add method for model #764

merged 24 commits into from
Apr 11, 2022

Conversation

BryanRumsey
Copy link
Contributor

No description provided.

@BryanRumsey BryanRumsey added the enhancement New feature or request label Mar 31, 2022
@BryanRumsey BryanRumsey added this to the 1.6.9 milestone Mar 31, 2022
@BryanRumsey BryanRumsey self-assigned this Mar 31, 2022
@BryanRumsey BryanRumsey marked this pull request as ready for review April 5, 2022 20:38
@BryanRumsey BryanRumsey linked an issue Apr 5, 2022 that may be closed by this pull request
Need single model.add() function to take all possible types #682
Closed
@ethangreen-dev ethangreen-dev self-requested a review April 5, 2022 21:12
ethangreen-dev
ethangreen-dev requested changes Apr 5, 2022
View reviewed changes
Copy link
Collaborator

@ethangreen-dev ethangreen-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests ran fine on my machine! (Python 3.8 and 3.9)

gillespy2/core/timespan.py Outdated Show resolved Hide resolved
gillespy2/core/timespan.py Outdated Show resolved Hide resolved
gillespy2/core/model.py Outdated Show resolved Hide resolved
gillespy2/core/timespan.py Outdated Show resolved Hide resolved
gillespy2/core/timespan.py Outdated Show resolved Hide resolved
gillespy2/core/timespan.py Show resolved Hide resolved
ethangreen-dev
ethangreen-dev requested changes Apr 7, 2022
View reviewed changes
Copy link
Collaborator

@ethangreen-dev ethangreen-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docstrings need a quick pass but everything else looks great!

gillespy2/core/model.py Outdated Show resolved Hide resolved
gillespy2/core/timespan.py Outdated Show resolved Hide resolved
@briandrawert briandrawert merged commit e85fc19 into develop Apr 11, 2022
@briandrawert briandrawert deleted the model-add branch April 11, 2022 18:44
@BryanRumsey BryanRumsey mentioned this pull request Apr 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethangreen-dev ethangreen-dev ethangreen-dev approved these changes

@briandrawert briandrawert briandrawert approved these changes

@seanebum seanebum Awaiting requested review from seanebum

Assignees

@BryanRumsey BryanRumsey

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.6.9
Development

Successfully merging this pull request may close these issues.

Need single model.add() function to take all possible types
3 participants
@BryanRumsey @briandrawert @ethangreen-dev