C++ solver seed tests, interrupt handler fixes
#701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Timeout not working on all solvers - Wrapped each solver in a subtest
- Added `GPY_INTERRUPT_*` macros for cross-platform signal handling - Added macro calls to each solver
- Reduced timeout in unit test to 0.1s - `ODECSolver` completes in <1s - Interrupt checks added to `TauHybridCSolver`
BryanRumsey
approved these changes
Jan 31, 2022
briandrawert
approved these changes
Feb 10, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test for simulation seeds and interrupts in newer C++ solvers by adding all C++ solvers to existing tests in
test_all_solvers.py. Additionally includes bug fixes for the interrupt functionality, which was uncovered by these tests.Changes
test_all_solvers.pyODECSolver,TauLeapingCSolver, andTauHybridCSolverCloses #695, #662