Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes for multi-event models #683

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

jtcooper10
Copy link
Collaborator

Bug Fixes

  • Fixed a bug where models with >2 events failed due to the event id being converted from int to bool, limiting the event id pool to {0,1}.
  • Fixed a bug where integrator errors were not being validated.

- Fixed return value for `get_event_id()`
- Removed duplicate trigger state update
- Added validation to `Integrator#integrate` wrapper method
@briandrawert briandrawert added this to the 1.6.8 milestone Jan 14, 2022
@briandrawert briandrawert merged commit 7876798 into develop Jan 14, 2022
@briandrawert briandrawert deleted the fix/hybrid-multi-event-models branch January 14, 2022 19:47
@seanebum seanebum mentioned this pull request Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants