Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLE solver #639

Merged
merged 8 commits into from
Dec 2, 2021
Merged

CLE solver #639

merged 8 commits into from
Dec 2, 2021

Conversation

briandrawert
Copy link
Member

No description provided.

@briandrawert briandrawert added the enhancement New feature or request label Nov 8, 2021
@briandrawert briandrawert added this to the 1.6.6 milestone Nov 8, 2021
@briandrawert briandrawert self-assigned this Nov 8, 2021
@briandrawert briandrawert linked an issue Nov 8, 2021 that may be closed by this pull request
Continuous SDE simulations of model possible? #637
Closed
@briandrawert briandrawert marked this pull request as draft November 8, 2021 05:03
@briandrawert briandrawert changed the title Initial commit of the CLE solver CLE solver Nov 10, 2021
@briandrawert briandrawert marked this pull request as ready for review November 18, 2021 17:46
@briandrawert briandrawert requested review from kevinsanft and removed request for BryanRumsey November 18, 2021 17:46
kevinsanft
kevinsanft approved these changes Dec 1, 2021
View reviewed changes
Copy link

@kevinsanft kevinsanft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean up the class docstring starting at "TODO: fix", otherwise ready.

@kevinsanft
Copy link

The "rc" variable could use a comment to explain what it does and what the special values 0 and 33 mean.

@seanebum seanebum merged commit 6958af6 into develop Dec 2, 2021
@seanebum seanebum deleted the ChemicalLangevinEquation_solver branch December 2, 2021 15:42
@seanebum seanebum mentioned this pull request Dec 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinsanft kevinsanft kevinsanft approved these changes

@seanebum seanebum Awaiting requested review from seanebum

Assignees

@briandrawert briandrawert

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.6.6
Development

Successfully merging this pull request may close these issues.

Continuous SDE simulations of model possible?
3 participants
@briandrawert @kevinsanft @seanebum