Value= fix #630
Merged
Value= fix #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Model and parameter to removed value=
This was
linked to
issues
Oct 21, 2021
Quick fix to model.py
Another quick fix to model.py
Hopefully last small change
Had to switch back to type error.
Had to get rid of test coverage code that reference now deleted set expression function from the parameter class
reverting to old try catch block code due to type error causing issues in test coverage
Got clarification on Type error issue. Added ParameterError back in and changed testing code
BryanRumsey
reviewed
Oct 25, 2021
BryanRumsey
reviewed
Oct 25, 2021
BryanRumsey
approved these changes
Oct 25, 2021
briandrawert
approved these changes
Oct 28, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed Model and parameter to removed value=