Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-Firing events don't work correctly in C++ TauHybrid solver #837

Closed
BryanRumsey opened this issue Jun 20, 2022 · 0 comments · Fixed by #841, #829 or #789
Closed

Multi-Firing events don't work correctly in C++ TauHybrid solver #837

BryanRumsey opened this issue Jun 20, 2022 · 0 comments · Fixed by #841, #829 or #789
Assignees
Labels
bug Something isn't working
Milestone

Comments

@BryanRumsey
Copy link
Contributor

This error only occurs when number_of_trajectories > 1.

Model

Multi-Firing Event Model

Code to Reproduce

model = create_multi_firing_event()
solver = gillespy2.TauHybridCSolver(model=model)

results1 = model.run(solver=gillespy2.TauHybridCSolver, number_of_trajectories=10)
results1.plot(title="Multi Firing Event Example w/o pre-instantiating the solver")

results2 = model.run(solver=solver, number_of_trajectories=10)
results2.plot(title="Multi Firing Event Example with pre-instantiating the solver")

Results

image
image

@BryanRumsey BryanRumsey added the bug Something isn't working label Jun 20, 2022
@BryanRumsey BryanRumsey added this to the 1.6.10 milestone Jun 20, 2022
@briandrawert briandrawert self-assigned this Jun 22, 2022
@briandrawert briandrawert linked a pull request Jun 22, 2022 that will close this issue
briandrawert added a commit that referenced this issue Jun 24, 2022
@BryanRumsey BryanRumsey linked a pull request Jun 28, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants