Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Translation Support for Sort by: in Home Page #2850

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

Ludy87
Copy link
Contributor

@Ludy87 Ludy87 commented Feb 2, 2025

Description of Changes

Summary

  • Added a new translation key home.sortBy in messages_en_GB.properties for "Sort by:".
  • Updated home.html to use the new translation key via th:text="#{home.sortBy}".
  • Ensures the "Sort by:" label is properly localized and can be translated into different languages.

Why the Change?

  • Improves internationalization (i18n) by allowing the "Sort by:" label to be translated.
  • Keeps consistency with other translatable UI elements.

Challenges Encountered

  • Ensuring that all relevant parts of the UI correctly reference the translation key.

Checklist

General

Documentation

UI Changes (if applicable)

  • Screenshots or videos demonstrating the UI changes are attached (e.g., as comments or direct attachments in the PR)

Testing (if applicable)

  • I have tested my changes locally. Refer to the Testing Guide for more details.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. enhancement New feature or request labels Feb 2, 2025
@github-actions github-actions bot added Front End Issues or pull requests related to front-end development Translation labels Feb 2, 2025
@Ludy87 Ludy87 changed the title Add home sortby Add: Translation Support for 'Sort by:' in Home Page Feb 2, 2025
Copy link
Contributor

github-actions bot commented Feb 2, 2025

🚀 Translation Verification Summary

🔄 Reference Branch: pr-branch-messages_en_GB.properties

📃 File Check: messages_en_GB.properties

  1. Test Status:Passed
  2. Test Status:Passed
  3. Test Status:Passed

✅ Overall Check Status: Success

Thanks @Ludy87 for your help in keeping the translations up to date.

@Ludy87 Ludy87 changed the title Add: Translation Support for 'Sort by:' in Home Page Add: Translation Support for Sort by: in Home Page Feb 2, 2025
@Ludy87
Copy link
Contributor Author

Ludy87 commented Feb 2, 2025

/deploypr

Copy link
Contributor

github-actions bot commented Feb 2, 2025

🚀 PR Test Deployment

Your PR has been deployed for testing!

🔗 Test URL: http://185.252.234.121:2850

This deployment will be automatically cleaned up when the PR is closed.

@Frooodle Frooodle merged commit bacc502 into Stirling-Tools:main Feb 3, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Front End Issues or pull requests related to front-end development size:XS This PR changes 0-9 lines, ignoring generated files. Translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants