-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colors (as in color-color or hardness-intensity diagrams) #781
Conversation
Hello @matteobachetti! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-01-15 10:50:12 UTC |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #781 +/- ##
===========================================
+ Coverage 79.07% 93.98% +14.91%
===========================================
Files 43 43
Lines 8697 8762 +65
===========================================
+ Hits 6877 8235 +1358
+ Misses 1820 527 -1293 ☔ View full report in Codecov by Sentry. |
e0585c9
to
52a776d
Compare
7c66b5f
to
aa25702
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! The usual nitpicky comments you expect from me, and a couple of questions. :)
stingray/base.py
Outdated
>>> np.allclose(res, 10) | ||
True | ||
""" | ||
from .gti import bin_intervals_from_gtis, time_intervals_from_gtis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
top-level import?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My main comment is that I'm not convinced by the behaviour in TimeSeries that suggests that event lists have dt=0. That seems very counterintuitive to me. Either event lists are also time series, in which case dt should be set to either the time resolution of the instrument, or to the intervals between events. I think by definition time series should not be allowed to have dt<=0, because that kind of defeats the purpose of a class that explicitly has one variable be ordered time. I would like to see if there's maybe a different mechanism to make that distinction that is also simple but doesn't break basic assumptions about how time series work?
@dhuppenkothen the problem is that some missions do not declare a time resolution. What do you use for dt then? 0 means simply that there is no known time resolution, or that it's probably irrelevant for the purpose of the analysis. |
12dcb07
to
60d2769
Compare
Ok, I changed the logic to eliminate some of the confusion, and eliminated method-level imports as promised ;) |
|
…to analyze GTIs one by one
cea9706
to
a2d292e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
Depends on #754