Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 11 Support #17

Merged
merged 13 commits into from
Feb 20, 2024
Merged

Laravel 11 Support #17

merged 13 commits into from
Feb 20, 2024

Conversation

sweptsquash
Copy link
Contributor

@sweptsquash sweptsquash commented Feb 16, 2024

This PR introduces support for Laravel 11. I've also updated Github Actions workflow to test against Laravel 9, 10 and 11 on PHP 8.0, 8.1, 8.2 and 8.3.

Linted with Laravel Pint.

@sweptsquash
Copy link
Contributor Author

@Sti3bas would be good to get your thoughts when you get a moment 😊

composer.json Outdated Show resolved Hide resolved
src/Fixtures/EmptySearchableModel.php Outdated Show resolved Hide resolved
@sweptsquash sweptsquash requested a review from Sti3bas February 20, 2024 09:16
@Sti3bas
Copy link
Owner

Sti3bas commented Feb 20, 2024

@sweptsquash can you please check why P8.1 - L9.* - prefer-lowest is failing?

@sweptsquash
Copy link
Contributor Author

@sweptsquash can you please check why P8.1 - L9.* - prefer-lowest is failing?

Sure thing. Looks like this test might be one that occasionally fails as it passed on my branch

@sweptsquash
Copy link
Contributor Author

@Sti3bas tests should now pass 😊 thank your for the feedback and taking the time to review this PR.

@Sti3bas Sti3bas merged commit bcc92fc into Sti3bas:master Feb 20, 2024
14 checks passed
@Sti3bas
Copy link
Owner

Sti3bas commented Feb 20, 2024

@sweptsquash hmm, strange, it still fails on master branch.

@sweptsquash
Copy link
Contributor Author

@sweptsquash hmm, strange, it still fails on master branch.

@Sti3bas I managed to find the issue that was causing this and it was an oversight on my part, made a PR for it #18

@Sti3bas
Copy link
Owner

Sti3bas commented Feb 21, 2024

@sweptsquash released in https://github.com/Sti3bas/laravel-scout-array-driver/releases/tag/v4.0

Thank you very much for your contribution and help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants