Skip to content

Commit

Permalink
chore(aws-secretsmanager): fix broken integration tests (aws#19698)
Browse files Browse the repository at this point in the history
Feature flag must be set for the validation lambda function to work
correctly


----

### All Submissions:

* [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)?
	* [ ] Did you use `cdk-integ` to deploy the infrastructure and generate the snapshot (i.e. `cdk-integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
corymhall authored and Stephen Potter committed Apr 27, 2022
1 parent 5df0352 commit 165b03f
Showing 1 changed file with 5 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ import * as path from 'path';
import * as cdk from '@aws-cdk/core';
import * as secretsmanager from '../lib';

/// !cdk-integ Integ-SecretsManager-ParsedSecretName pragma:set-context:@aws-cdk/aws-secretsmanager:parseOwnedSecretName=true

/**
* Creates several secrets, with varying names and IDs, with the parseOwnedSecretName feature flag set,
* to verify the secretName returned by `Secret.secretName` matches the `Name` returned by `DescribeSecrets`.
Expand Down Expand Up @@ -39,6 +41,9 @@ class SecretsManagerStack extends cdk.Stack {
}

const app = new cdk.App({
context: {
'@aws-cdk/aws-secretsmanager:parseOwnedSecretName': true,
},
});
new SecretsManagerStack(app, 'Integ-SecretsManager-ParsedSecretName');
app.synth();

0 comments on commit 165b03f

Please sign in to comment.