-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/Перейти на OrderedDictionary в FunctionWithUndefinedReturnStorage (.NET 9+) #121
Feature/Перейти на OrderedDictionary в FunctionWithUndefinedReturnStorage (.NET 9+) #121
Conversation
Minimum allowed coverage is Generated by 🐒 cobertura-action against b931f61 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Хороший PR! До мержа надо сделать 3 вещи:
- Обновить пайплайн на 9 дотнет
- Добавить тест на проверку сохранения порядка - вставил 4 элемента, удалил 2й, Flush вернул 1 3 4. Тестовый класс уже есть, сможешь через usages найти
- Обновить Readme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Всё супер, но расширение стоит убрать и начинку метода поместить внутрь Select делегата внутри Flush
Description
Переход на лаконичный, более подходящий для данного сценария тип OrderedDictionary
Related Issues
#82