Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Перейти на OrderedDictionary в FunctionWithUndefinedReturnStorage (.NET 9+) #121

Merged

Conversation

hw2cb
Copy link
Contributor

@hw2cb hw2cb commented Jan 30, 2025

Description

Переход на лаконичный, более подходящий для данного сценария тип OrderedDictionary

Related Issues

#82

Copy link

github-actions bot commented Jan 30, 2025

File Coverage Branches Missing
All files 45% 43%

Minimum allowed coverage is 20%

Generated by 🐒 cobertura-action against b931f61

Copy link
Owner

@Stepami Stepami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Хороший PR! До мержа надо сделать 3 вещи:

  1. Обновить пайплайн на 9 дотнет
  2. Добавить тест на проверку сохранения порядка - вставил 4 элемента, удалил 2й, Flush вернул 1 3 4. Тестовый класс уже есть, сможешь через usages найти
  3. Обновить Readme

@Stepami Stepami added this to the v2.1.0 milestone Jan 31, 2025
Copy link
Owner

@Stepami Stepami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Всё супер, но расширение стоит убрать и начинку метода поместить внутрь Select делегата внутри Flush

@Stepami Stepami merged commit 7aad345 into Stepami:master Feb 1, 2025
2 checks passed
@Stepami Stepami removed this from the v2.1.0 milestone Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] Перейти на OrderedDictionary в FunctionWithUndefinedReturnStorage (.NET 9+)
2 participants