-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature request] Вынести создание координат в сервис ITextCoordinateSystemComputer #109
Labels
Milestone
Comments
Stepami
added a commit
that referenced
this issue
Aug 20, 2024
Stepami
added a commit
that referenced
this issue
Aug 20, 2024
Stepami
added a commit
that referenced
this issue
Aug 25, 2024
* #103 - вернул префикс (#104) * #105 - fix GitVersion.yml +semver:skip (#106) * #105 - fix GitVersion.yml * #105 - label->tag * #97 - внедрение логгера (#108) * #97 - rename logging -> dumping * #97 - refactoring of writer entity * #97 - реализация вывода с помощью логгера * #97 - реализация форматтера для эквивалентного вывода * #97 - работа с логгером в тестах * Улучшения работы с текстовыми координатами (#110) * #107 - оптимизация ITextCoordinateSystemComputer.GetLines * #107 - правка тестов * #109 - Вынос логики построения координат в сервис * #109 - тесты --------- Co-authored-by: StefanioHabrArticles <120809256+StefanioHabrArticles@users.noreply.github.com>
Stepami
added a commit
that referenced
this issue
Feb 2, 2025
Stepami
added a commit
that referenced
this issue
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Is your feature request related to a problem? Please describe.
Конструктор класса Coordinate https://github.com/Stepami/hydrascript/blob/master/src/Domain/HydraScript.Domain.FrontEnd/Lexer/Token.cs#L42
Обладает слишком сложной реализацией с неположенной ответственностью:
Describe the solution you'd like
Необходимо перенести логику вычисления координаты (Строка, Столбец) из пары (индекс, переносы строк) внутрь сервиса ITextCoordinateSystemComputer
The text was updated successfully, but these errors were encountered: