Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat icons to use Avatar option #42

Closed
Cull3411 opened this issue Sep 23, 2021 · 2 comments
Closed

Chat icons to use Avatar option #42

Cull3411 opened this issue Sep 23, 2021 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@Cull3411
Copy link

I use Animated Tokens and they don't print to the chat. I get a broken link icon instead.
I use .webm on some of my Tokens.

Perhaps look for a .png of the same name in the same directory. The user would be expected to have an appropriate .png in the right place if they use a .webm token.

Or, I imagine a more difficult option, provide an Avatar or Token checkbox.

@Stendarpaval Stendarpaval added the bug Something isn't working label Sep 25, 2021
@Stendarpaval Stendarpaval self-assigned this Sep 25, 2021
Stendarpaval added a commit that referenced this issue Sep 25, 2021
-  Added the "mobUpdate" hook which is called each time the list of saved mobs is updated, to further improve compatibility with the Combat Tracker Groups (CTG) module.
- Added another publically available function: `MobAttacks.deleteSavedMob`, for modules or macros to work with saved mobs.
- Specifically for CTG, I added a third function: `MobAttacks.createSavedMobsFromCTGgroups` (sorry for the unimaginative name). This function converts arrays of arrays of combatants into saved mobs. It has an optional argument for an array of mob names, but without being given that array it will generate mob names on its own.
- Added support for token images that use the .webm format, related to issue #42.
@Stendarpaval
Copy link
Owner

This was an interesting bug to look into, thanks for reporting it!

After reproducing the issue, I noticed that Midi-QOL's apply damage message's token image was displaying properly. So I looked into how they achieved that, and was able to use the same method.

So, as of v0.3.10 which released just now, .webm token images will display properly in chat messages, as well as the target tab of the Mob Attack dialog.

I could also add a setting to choose between actor or token image, but I reckon that most DMs prefer to use the token image since shapeshifter actors might have a different actor image. Please let me know if you'd like me to add that setting anyway, or if you run into any other problems with token images. :)

@Stendarpaval
Copy link
Owner

I'll go ahead and close this issue. If similar issues pop up, feel free to re-open it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants