Bugfixes for indirect permissions #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Arthurvdv can you have a look why the builds are failing for those old versions here? |
|
The problem is caused by namespaces, which aren't there in the beginning of the v12.0 versions of AL. You need to wrap these with a preprocessor directive, for example see rule 0039: |
Arthurvdv
reviewed
Aug 20, 2024
| @@ -213,20 +214,20 @@ private void CheckProcedureInvocation(IPropertySymbol objectPermissions, string | |||
| var objectName = typeAndObjectName[typeEndIndex..].Trim().Trim('"'); | |||
|
|
|||
| // Match against the parameters of the procedure | |||
| if (type == "tabledata" && objectName == variableTypeName.ToLowerInvariant()) | |||
| if (type == "tabledata" && (objectName == variableType.Name.ToLowerInvariant() || objectName.Replace("\"","") == (variableType.OriginalDefinition.ContainingNamespace.QualifiedName.ToLowerInvariant() + "." + variableType.Name.ToLowerInvariant()))) | |||
There was a problem hiding this comment.
You can probarly use the .UnquoteIdentifier instead of .Replace(""","")
There was a problem hiding this comment.
at this point its just a string, so I dont think that method is available
There was a problem hiding this comment.
It's a stringExtension, so I should work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.