Companial Cop - PR: Analyze Transfer Fields #429
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new rule to analyze table pairs coupled using TransferFields.
First, it analyzes all TableExtensions in the code base, if any TableExts are part of the hardcoded table pairs that were found in the BaseApp, then all fields that have the same ID in both objects need also to have the same name and type.
Next, it finds all TransferFields invocations in the code. It analyzes three different situations:
I went through most of the BaseApp to find as many table pairs as possible. I might have missed some.
A possible extension to this rule is to include some settings file, where per project, you could add additional table pairs that are coupled in other dependencies, besides BaseApp.