Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable LC003 and LC005 for DotNet var/param names #119

Conversation

rvanbekkum
Copy link
Contributor

For the time being, until #95 gets resolved in a better way, this PR will disable the checks for variables, parameters and also return variable names with DotNet as data type (even though the latter cannot have DotNet as data-type).
Note that the check for the casing of DotNet itself still works, but the subtype check is skipped.

@StefanMaron
Copy link
Owner

Thanks for looking into this. I need to be honest that dotnet is not at the top of my list. Would it be okay for you if we close #95 with this fix/workaround?

@rvanbekkum
Copy link
Contributor Author

Yes, that is fine. 😊

@StefanMaron StefanMaron changed the base branch from development to prerelease December 27, 2021 09:15
@StefanMaron StefanMaron added the bug Something isn't working label Dec 27, 2021
@StefanMaron StefanMaron linked an issue Dec 27, 2021 that may be closed by this pull request
@StefanMaron StefanMaron merged commit 357f0c4 into StefanMaron:prerelease Dec 27, 2021
@rvanbekkum rvanbekkum deleted the feature/95-disable-check-for-dotnet-variable-and-parameter-names branch January 3, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LC0005 False positive on DotNet datatypes (N.B. Allow aliases)
2 participants