Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for: IDs Instead of Names #4

Closed
aptMattKoe opened this issue Sep 20, 2021 · 9 comments
Closed

Check for: IDs Instead of Names #4

aptMattKoe opened this issue Sep 20, 2021 · 9 comments
Labels

Comments

@aptMattKoe
Copy link

There is no good reason to use an ID as SourceTable or in variables, parameters instead of the Names.

@StefanMaron
Copy link
Owner

Would you mind to test this rule? 😎
Otherwise I would close this issue in a few days

@ChristianHovenbitzer
Copy link
Contributor

The rule seems to trigger on every property with a number in it. This includes:

  • Descriptions
  • Tooltips
  • Captions
  • DecimalPlace
  • Width

@aptMattKoe
Copy link
Author

I've tested it and it works for me! :) thanks!

@aptMattKoe
Copy link
Author

The rule seems to trigger on every property with a number in it. This includes:

  • Descriptions
  • Tooltips
  • Captions
  • DecimalPlace
  • Width

Could you take a screenshot? My Tests are not doing this.

@StefanMaron
Copy link
Owner

I think I fixed it meanwhile 😜
Sorry I forgot to mention.

Anyways. there are still issues:

  • numbers in object name should not trigger this warning
  • direct id usage in like codeunit.Run(1) should trigger this warning

@StefanMaron
Copy link
Owner

StefanMaron commented Sep 24, 2021

Numbers in Object Names should not trigger the warning anymore.
direct usage of codeunit.Run(1) should be a separate rule I think See #16

@ChristianHovenbitzer
Copy link
Contributor

Codeunit Permissions falsely trigger warnings
image

@StefanMaron
Copy link
Owner

Good catch, will look into this later 👍

@StefanMaron
Copy link
Owner

Should be fixed with version 0.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants