Resolve false positive (#859)

StefanMaron · Jan 7, 2025 · f0f05ce · f0f05ce
1 parent 655949a
commit f0f05ce
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 1 deletion.
diff --git a/BusinessCentral.LinterCop.Test/Rule0075.cs b/BusinessCentral.LinterCop.Test/Rule0075.cs
@@ -38,6 +38,7 @@ public async Task HasDiagnostic(string testCase)
     [TestCase("ImplicitConversiontIntegerToEnum")]
     [TestCase("ImplicitConversiontLabelToCode")]
     [TestCase("RecordGetBuiltInMethodRecordId")]
+    [TestCase("RecordGetCode10ToCode20")]
     [TestCase("RecordGetFieldRecordId")]
     [TestCase("RecordGetGlobalVariable")]
     [TestCase("RecordGetLocalVariable")]

diff --git a/BusinessCentral.LinterCop.Test/TestCases/Rule0075/NoDiagnostic/RecordGetCode10ToCode20.al b/BusinessCentral.LinterCop.Test/TestCases/Rule0075/NoDiagnostic/RecordGetCode10ToCode20.al
@@ -0,0 +1,17 @@
+codeunit 50100 MyCodeunit
+{
+    procedure MyProcedure(MyCode: Code[10])
+    var
+        MyTabe: Record MyTabe;
+    begin
+        [|MyTabe.Get(MyCode)|];
+    end;
+}
+
+table 50100 MyTabe
+{
+    fields
+    {
+        field(1; MyField; Code[20]) { }
+    }
+}
diff --git a/BusinessCentral.LinterCop/Design/Rule0075RecordGetProcedureArguments.cs b/BusinessCentral.LinterCop/Design/Rule0075RecordGetProcedureArguments.cs
@@ -119,7 +119,7 @@ private bool AreFieldCompatible(IArgument argument, IFieldSymbol field)
         if (argumentNavType == NavTypeKind.Enum && fieldNavType == NavTypeKind.Enum)
             return argumentType.OriginalDefinition == fieldType.OriginalDefinition;
 
-        if ((argumentNavType == fieldNavType && argumentType.Length == fieldType.Length) ||
+        if ((argumentNavType == fieldNavType && argumentType.Length <= fieldType.Length) ||
            argumentNavType == NavTypeKind.None ||
            argumentNavType == NavTypeKind.Joker)
             return true;