Rule0015 Show warning if table data permission is missing

StefanMaron · Jan 26, 2022 · eae67f9 · eae67f9
1 parent 56c923f
commit eae67f9
Showing 1 changed file with 14 additions and 8 deletions.
diff --git a/Design/Rule0015PermissionSetCoverage.cs b/Design/Rule0015PermissionSetCoverage.cs
@@ -43,6 +43,11 @@ private void CheckPermissionSetCoverage(SymbolAnalysisContext context)
                 PermissionObjectKind permObjectKind = PermissionObjectKind.Table;
                 int permObjectId = appObjTypeSymbol.Id;
 
+                if (appObjTypeSymbol.IsObsoleteRemoved)
+                {
+                    continue;
+                }
+
                 switch (appObjTypeSymbol.NavTypeKind)
                 {
                     case NavTypeKind.Codeunit:
@@ -57,24 +62,25 @@ private void CheckPermissionSetCoverage(SymbolAnalysisContext context)
                     case NavTypeKind.Report:
                         permObjectKind = PermissionObjectKind.Report;
                         break;
-                    case NavTypeKind.Table:
+                    case NavTypeKind.Record:
                         permObjectKind = PermissionObjectKind.Table;
                         break;
                     case NavTypeKind.XmlPort:
                         permObjectKind = PermissionObjectKind.Xmlport;
                         break;
                 }
 
-                if (appObjTypeSymbol.IsObsoleteRemoved)
-                {
-                    continue;
-                }
-                if (permissionSymbols.Contains((permObjectKind, permObjectId)) || permissionSymbols.Contains((permObjectKind, 0)) || XmlPermissionExistsForObject(permissionSetDocuments, permObjectKind, permObjectId))
+                if (!(permissionSymbols.Contains((permObjectKind, permObjectId)) || permissionSymbols.Contains((permObjectKind, 0)) || XmlPermissionExistsForObject(permissionSetDocuments, permObjectKind, permObjectId)))
+                    context.ReportDiagnostic(Diagnostic.Create(DiagnosticDescriptors.Rule0015PermissionSetCoverage, current.GetLocation(), new Object[] { permObjectKind.ToString(), appObjTypeSymbol.Name }));
+
+                if (appObjTypeSymbol.NavTypeKind == NavTypeKind.Record)
                 {
-                    continue;
+                    permObjectKind = PermissionObjectKind.TableData;
+
+                    if (!(permissionSymbols.Contains((permObjectKind, permObjectId)) || permissionSymbols.Contains((permObjectKind, 0)) || XmlPermissionExistsForObject(permissionSetDocuments, permObjectKind, permObjectId)))
+                        context.ReportDiagnostic(Diagnostic.Create(DiagnosticDescriptors.Rule0015PermissionSetCoverage, current.GetLocation(), new Object[] { permObjectKind.ToString(), appObjTypeSymbol.Name }));
                 }
 
-                context.ReportDiagnostic(Diagnostic.Create(DiagnosticDescriptors.Rule0015PermissionSetCoverage, current.GetLocation(), new Object[] { permObjectKind.ToString(), appObjTypeSymbol.Name }));
             }
         }