Improve Diagnostic message format

StefanMaron · Jan 25, 2025 · d623487 · d623487
1 parent 6820990
commit d623487
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 14 deletions.
diff --git a/BusinessCentral.LinterCop/Design/Rule0083BuiltInDateTimeMethod.cs b/BusinessCentral.LinterCop/Design/Rule0083BuiltInDateTimeMethod.cs
@@ -31,8 +31,8 @@ private void AnalyzeInvocation(OperationAnalysisContext ctx)
         {
             "Date2DMY" => GetDate2DMYReplacement(operation),
             "Date2DWY" => GetDate2DWYReplacement(operation),
-            "DT2Date" => "Date",
-            "DT2Time" => "Time",
+            "DT2Date" => "Date()",
+            "DT2Time" => "Time()",
             "Format" => GetFormatReplacement(operation),
             _ => null
         };
@@ -43,7 +43,7 @@ private void AnalyzeInvocation(OperationAnalysisContext ctx)
         ctx.ReportDiagnostic(Diagnostic.Create(
             DiagnosticDescriptors.Rule0083BuiltInDateTimeMethod,
             ctx.Operation.Syntax.GetLocation(),
-            operation.Arguments[0].Value.Syntax.ToString().QuoteIdentifierIfNeeded(),
+            operation.Arguments[0].Value.Syntax.ToString(),
             recommendedMethod));
     }
 
@@ -54,9 +54,9 @@ private void AnalyzeInvocation(OperationAnalysisContext ctx)
 
         return operation.Arguments[1].Value.ConstantValue.Value switch
         {
-            1 => "Day",
-            2 => "Month",
-            3 => "Year",
+            1 => "Day()",
+            2 => "Month()",
+            3 => "Year()",
             _ => "<Day/Month/Year>"
         };
     }
@@ -70,8 +70,8 @@ private void AnalyzeInvocation(OperationAnalysisContext ctx)
 
         return formatSpecifier switch
         {
-            1 => "DayOfWeek",
-            2 => "Year",
+            1 => "DayOfWeek()",
+            2 => "Year()",
             _ => "<DayOfWeek/Year>"
         };
     }
@@ -81,12 +81,12 @@ private void AnalyzeInvocation(OperationAnalysisContext ctx)
         if (operation.Arguments.Length < 3)
             return string.Empty;
 
-        return  operation.Arguments[2].Value.ConstantValue.Value?.ToString() switch
+        return operation.Arguments[2].Value.ConstantValue.Value?.ToString() switch
         {
-            "<HOURS24>" => "Hour",
-            "<MINUTES>" => "Minute",
-            "<SECONDS>" => "Second",
-            "<THOUSANDS>" => "Millisecond",
+            "<HOURS24>" => "Hour()",
+            "<MINUTES>" => "Minute()",
+            "<SECONDS>" => "Second()",
+            "<THOUSANDS>" => "Millisecond()",
             _ => string.Empty
         };
     }

diff --git a/BusinessCentral.LinterCop/LinterCopAnalyzers.resx b/BusinessCentral.LinterCop/LinterCopAnalyzers.resx
@@ -862,7 +862,7 @@
     <value>Use new Date/Time/DateTime methods for extracting parts.</value>
   </data>
   <data name="Rule0083BuiltInDateTimeMethodFormat" xml:space="preserve">
-    <value>Use the new method '{0}.{1}' to extract specific parts of date/time values.</value>
+    <value>Use the new method {0}.{1} to extract specific parts of date/time values.</value>
   </data>
   <data name="Rule0083BuiltInDateTimeMethodDescription" xml:space="preserve">
     <value>Replace outdated functions for extracting specific parts of Date, Time, and DateTime types (such as day, month, hour, or second) with the new, modernized methods.</value>