Bugfix for #166

Fields coming from system tables dont need a caption API Pages dont need a caption
StefanMaron · Mar 5, 2022 · c4340e3 · c4340e3
1 parent db583a2
commit c4340e3
Showing 1 changed file with 21 additions and 0 deletions.
diff --git a/Design/Rule0016CheckForMissingCaptions.cs b/Design/Rule0016CheckForMissingCaptions.cs
@@ -34,8 +34,14 @@ private void CheckForMissingCaptions(SymbolAnalysisContext context)
                     case ControlKind.Field:
                         if (CaptionIsMissing(context.Symbol, context))
                             if (Control.RelatedFieldSymbol != null)
+                            {
                                 if (CaptionIsMissing(Control.RelatedFieldSymbol, context))
                                     RaiseCaptionWarning(context);
+                            }
+                            else
+                            {
+                                RaiseCaptionWarning(context);
+                            }
                         break;
 
                     case ControlKind.Area:
@@ -78,6 +84,12 @@ private void CheckForMissingCaptions(SymbolAnalysisContext context)
                         break;
                 }
             }
+            if (context.Symbol.Kind == SymbolKind.Page)
+            {
+                if (((IPageTypeSymbol)context.Symbol).PageType != PageTypeKind.API)
+                    if (CaptionIsMissing(context.Symbol, context))
+                        RaiseCaptionWarning(context);
+            }
             else
             {
                 if (CaptionIsMissing(context.Symbol, context))
@@ -87,6 +99,15 @@ private void CheckForMissingCaptions(SymbolAnalysisContext context)
 
         private bool CaptionIsMissing(ISymbol Symbol, SymbolAnalysisContext context)
         {
+            try
+            {
+                if (Symbol.ContainingType.Kind == SymbolKind.Table)
+                    if (((ITableTypeSymbol)Symbol.ContainingType).Id >= 2000000000)
+                        return false;
+            }
+            catch (NullReferenceException)
+            { }
+
             if (Symbol.GetBooleanPropertyValue(PropertyKind.ShowCaption) != false)
                 if (Symbol.GetProperty(PropertyKind.Caption) == null && Symbol.GetProperty(PropertyKind.CaptionClass) == null)
                     return true;