-
Notifications
You must be signed in to change notification settings - Fork 32
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #356 from StefanMaron/development
New rule LC0033 runtime falling behind
- Loading branch information
Showing
3 changed files
with
95 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| using Microsoft.Dynamics.Nav.Analyzers.Common.AppSourceCopConfiguration; | ||
| using Microsoft.Dynamics.Nav.CodeAnalysis; | ||
| using Microsoft.Dynamics.Nav.CodeAnalysis.Diagnostics; | ||
| using Microsoft.Dynamics.Nav.CodeAnalysis.Packaging; | ||
| using System.Collections.Immutable; | ||
|
|
||
| namespace BusinessCentral.LinterCop.Design | ||
| { | ||
| [DiagnosticAnalyzer] | ||
| class Rule0033AppManifestRuntimeBehind : DiagnosticAnalyzer | ||
| { | ||
| public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics { get; } = ImmutableArray.Create<DiagnosticDescriptor>(DiagnosticDescriptors.Rule0033AppManifestRuntimeBehind); | ||
|
|
||
| public override void Initialize(AnalysisContext context) => context.RegisterCompilationAction(new Action<CompilationAnalysisContext>(this.CheckAppManifestRuntime)); | ||
|
|
||
| private void CheckAppManifestRuntime(CompilationAnalysisContext ctx) | ||
| { | ||
| NavAppManifest manifest = AppSourceCopConfigurationProvider.GetManifest(ctx.Compilation); | ||
| if (manifest == null) return; | ||
| if (manifest.Runtime == (Version)null) return; | ||
|
|
||
| GetTargetProperty(manifest, out string propertyName, out Version propertyVersion); | ||
|
|
||
| Version supportedRuntime = FindValueOfFirstValueLessThan(GetSupportedRuntimeVersions(), propertyVersion); | ||
| if (manifest.Runtime < supportedRuntime) | ||
| ctx.ReportDiagnostic(Diagnostic.Create(DiagnosticDescriptors.Rule0033AppManifestRuntimeBehind, manifest.GetDiagnosticLocation("runtime"), new object[] { propertyName, propertyVersion, manifest.Runtime, supportedRuntime })); | ||
| } | ||
|
|
||
| private static void GetTargetProperty(NavAppManifest manifest, out string propertyName, out Version propertyVersion) | ||
| { | ||
| if (manifest.Application >= manifest.Platform) | ||
| { | ||
| propertyName = "application"; | ||
| propertyVersion = manifest.Application; | ||
| } | ||
| else | ||
| { | ||
| propertyName = "platform"; | ||
| propertyVersion = manifest.Platform; | ||
| } | ||
| } | ||
|
|
||
| private static SortedList<Version, Version> GetSupportedRuntimeVersions() | ||
| { | ||
| // Populate a SortedList with platform version and runtime version combined | ||
| SortedList<Version, Version> AvailableRuntimeVersion = new SortedList<Version, Version>(); | ||
|
|
||
| // https://learn.microsoft.com/en-us/dynamics365/business-central/dev-itpro/developer/devenv-choosing-runtime#currently-available-runtime-versions | ||
| // When in the future the offset between the platform and runtime versions isn't exactly is eleven, we're in trouble | ||
| // By populating a list here, in stead of just adding up eleven somewhere else, we probably can resolve this here | ||
| int offset = 11; | ||
|
|
||
| foreach (var v in RuntimeVersion.SupportedVersions) | ||
| { | ||
| AvailableRuntimeVersion.Add(new Version(v.Major + offset, v.Minor), new Version(v.Major, v.Minor)); | ||
| } | ||
| return AvailableRuntimeVersion; | ||
| } | ||
|
|
||
| private static Version FindValueOfFirstValueLessThan(SortedList<Version, Version> sortedList, Version version) | ||
| { | ||
| int index = FindIndexOfFirstValueLessThan(sortedList.Keys.ToList(), version); | ||
| return sortedList.ElementAt(index).Value; | ||
| } | ||
|
|
||
| private static int FindIndexOfFirstValueLessThan<T>(List<T> sortedList, T value, IComparer<T> comparer = null) | ||
| { | ||
| var index = sortedList.BinarySearch(value, comparer); | ||
|
|
||
| // The value was found in the list. Just return its index. | ||
| if (index >= 0) | ||
| return index; | ||
|
|
||
| // The value was not found and "~index" is the index of the next value greater than the search value. | ||
| index = ~index; | ||
|
|
||
| // There are values in the list less than the search value. Return the index of the closest one. | ||
| if (index > 0) | ||
| return index - 1; | ||
|
|
||
| // All values in the list are greater than the search value. | ||
| return -1; | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters