Bugfix for #178

Systems fields do not need captions on pages
StefanMaron · Mar 20, 2022 · 231f5a0 · 231f5a0
1 parent 3cfd5ec
commit 231f5a0
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/Design/Rule0016CheckForMissingCaptions.cs b/Design/Rule0016CheckForMissingCaptions.cs
@@ -102,8 +102,12 @@ private bool CaptionIsMissing(ISymbol Symbol, SymbolAnalysisContext context)
             try
             {
                 if (Symbol.ContainingType.Kind == SymbolKind.Table)
+                {
                     if (((ITableTypeSymbol)Symbol.ContainingType).Id >= 2000000000)
                         return false;
+                    if (((IFieldSymbol)Symbol).Id >= 2000000000)
+                        return false;
+                }
             }
             catch (NullReferenceException)
             { }

diff --git a/Design/Rule0017WriteToFlowField.cs b/Design/Rule0017WriteToFlowField.cs
@@ -48,14 +48,19 @@ private void CheckForWriteToFlowField(OperationAnalysisContext context)
             else
             {
                 IAssignmentStatement operation = (IAssignmentStatement)context.Operation;
-                if (operation.Target.Kind == OperationKind.FieldAccess && ((ITextIndexAccess)operation.Target).TextExpression.Kind == OperationKind.FieldAccess)
+                if (operation.Target.Kind == OperationKind.FieldAccess)
                 {
                     try
                     {
                         var FieldClass = FieldClassKind.Normal;
 
                         if (operation.Target.Syntax.Kind == SyntaxKind.ArrayIndexExpression)
+                        {
+                            if (((ITextIndexAccess)operation.Target).TextExpression.Kind != OperationKind.FieldAccess)
+                                return;
+
                             FieldClass = ((IFieldAccess)((ITextIndexAccess)operation.Target).TextExpression).FieldSymbol.FieldClass;
+                        }
                         else
                             FieldClass = ((IFieldAccess)operation.Target).FieldSymbol.FieldClass;