Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Management Samples #343

Merged
merged 27 commits into from
Dec 19, 2024
Merged

Replace Management Samples #343

merged 27 commits into from
Dec 19, 2024

Conversation

TimHess
Copy link
Member

@TimHess TimHess commented Oct 23, 2024 •
edited
Loading

Consolidate and update Management samples

Blocked by SteeltoeOSS/Steeltoe#1389

Resolves #341

part of #319

Related to SteeltoeOSS/Steeltoe#1416

@TimHess TimHess added Component/Management Issues related to Steeltoe Management (actuators) ReleaseLine/4.x labels Oct 23, 2024
@TimHess TimHess self-assigned this Oct 23, 2024
@TimHess TimHess mentioned this pull request Oct 23, 2024
Closed
@TimHess TimHess marked this pull request as ready for review October 28, 2024 21:31
TimHess
TimHess commented Oct 28, 2024
View reviewed changes
steps/browser_steps.py Show resolved Hide resolved
steps/browser_steps.py Show resolved Hide resolved
@TimHess TimHess requested a review from bart-vmware October 29, 2024 14:12
@bart-vmware

This comment was marked as resolved.

Sign in to view
bart-vmware
bart-vmware requested changes Oct 30, 2024
View reviewed changes
Connectors/src/CosmosDb/Program.cs Outdated Show resolved Hide resolved
Management/src/ActuatorApi/README.md Outdated Show resolved Hide resolved
@bart-vmware

This comment was marked as resolved.

Sign in to view
@bart-vmware

This comment was marked as resolved.

Sign in to view
@bart-vmware

This comment was marked as resolved.

Sign in to view
@bart-vmware

This comment was marked as resolved.

Sign in to view
bart-vmware
bart-vmware requested changes Oct 30, 2024
View reviewed changes
Management/src/ActuatorApi/README.md Outdated Show resolved Hide resolved
@bart-vmware

This comment was marked as resolved.

Sign in to view
@bart-vmware

This comment was marked as resolved.

Sign in to view
@bart-vmware

This comment was marked as resolved.

Sign in to view
bart-vmware
bart-vmware requested changes Oct 30, 2024
View reviewed changes
Management/src/ActuatorApi/Models/WeatherForecast.cs Show resolved Hide resolved
Management/src/ActuatorApi/Directory.Build.props Show resolved Hide resolved
Management/src/ActuatorApi/MySqlSeeder.cs Outdated Show resolved Hide resolved
Management/src/ActuatorApi/MySqlSeeder.cs Outdated Show resolved Hide resolved
Management/src/ActuatorApi/Program.cs Outdated Show resolved Hide resolved
Management/src/ActuatorApi/BasicAuthExtensions.cs Outdated Show resolved Hide resolved
Management/src/ActuatorApi/Properties/launchSettings.json Show resolved Hide resolved
Management/src/ActuatorApi/Properties/launchSettings.json Outdated Show resolved Hide resolved
Management/src/ActuatorWeb/Program.cs Show resolved Hide resolved
Management/src/ActuatorWeb/Program.cs Outdated Show resolved Hide resolved
@TimHess

This comment was marked as resolved.

Sign in to view
@TimHess TimHess requested a review from bart-vmware November 4, 2024 23:01
bart-vmware
bart-vmware reviewed Nov 5, 2024
View reviewed changes
Copy link
Member

@bart-vmware bart-vmware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gone over most of the files again, but haven't run anything yet.

There are quite some TODOs in the readme, can you move them to separate issues if they won't be addressed in this PR?

Management/src/ActuatorApi/WeatherEndpoints.cs Outdated Show resolved Hide resolved
Management/src/ActuatorApi/AdminTasks/ForecastTask.cs Outdated Show resolved Hide resolved
Management/src/ActuatorApi/AdminTasks/ForecastTask.cs Outdated Show resolved Hide resolved
Management/src/ActuatorApi/BasicAuthExtensions.cs Outdated Show resolved Hide resolved
Management/src/ActuatorApi/Data/WeatherContext.cs Outdated Show resolved Hide resolved
Management/src/ActuatorWeb/Pages/Error.cshtml Show resolved Hide resolved
Management/src/ActuatorWeb/Pages/Shared/_Layout.cshtml Outdated Show resolved Hide resolved
Management/src/ActuatorWeb/Properties/launchSettings.json Outdated Show resolved Hide resolved
Management/src/ActuatorWeb/Properties/launchSettings.json Show resolved Hide resolved
Management/src/ActuatorWeb/README.md Outdated Show resolved Hide resolved
@TimHess

This comment was marked as resolved.

Sign in to view
@TimHess TimHess requested a review from bart-vmware November 6, 2024 14:24
bart-vmware
bart-vmware reviewed Nov 15, 2024
View reviewed changes
Management/src/ActuatorApi/git.properties Outdated Show resolved Hide resolved
Management/src/ActuatorWeb/OpenTelemetryExtensions.cs Outdated Show resolved Hide resolved
Management/src/README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
CommonTasks.md Outdated Show resolved Hide resolved
Management/src/ActuatorWeb/Properties/launchSettings.json Show resolved Hide resolved
@TimHess TimHess mentioned this pull request Nov 15, 2024
Closed
bart-vmware added a commit that referenced this pull request Dec 3, 2024
@bart-vmware
Extract non-management improvements from #343
ccc1391
@bart-vmware bart-vmware mentioned this pull request Dec 3, 2024
Merged
bart-vmware added a commit that referenced this pull request Dec 4, 2024
@bart-vmware
Update samples v4 (#346)
c1fc732 
* Extract non-management improvements from #343

* Reduce logging in ConfigServer sample (output flooded by placeholder logs otherwise)

* Update SBA port number
@TimHess TimHess requested a review from bart-vmware December 18, 2024 22:46
TimHess and others added 2 commits December 19, 2024 09:00
@TimHess @bart-vmware
Update Management/src/ActuatorApi/Program.cs
36dc3f2 
Co-authored-by: Bart Koelman <104792814+bart-vmware@users.noreply.github.com>
@TimHess
whitespace, comment updates, remove heapdump from .http
7f4e8e0
@TimHess @bart-vmware
Apply suggestions from code review
a789352 
Co-authored-by: Bart Koelman <104792814+bart-vmware@users.noreply.github.com>
@TimHess TimHess requested a review from bart-vmware December 19, 2024 16:56
bart-vmware
bart-vmware approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@bart-vmware bart-vmware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@TimHess TimHess merged commit 77d9dd6 into latest Dec 19, 2024
1 of 10 checks passed
@TimHess TimHess deleted the management branch December 19, 2024 17:19
@TimHess TimHess mentioned this pull request Dec 19, 2024
Open
@bart-vmware bart-vmware mentioned this pull request Dec 20, 2024
Closed
@TimHess TimHess linked an issue Dec 20, 2024 that may be closed by this pull request
Consolidate and update Management Samples #325
Closed
@bart-vmware bart-vmware mentioned this pull request Dec 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bart-vmware bart-vmware bart-vmware approved these changes

Assignees

@TimHess TimHess

Labels
Component/Management Issues related to Steeltoe Management (actuators) ReleaseLine/4.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consolidate and update Management Samples
2 participants
@TimHess @bart-vmware