Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Application Configuration Service example #318

Merged
merged 21 commits into from
Mar 28, 2024
Merged

Add Application Configuration Service example #318

merged 21 commits into from
Mar 28, 2024

Conversation

TimHess
Copy link
Member

@TimHess TimHess commented Mar 8, 2024

Also begin merging all the config samples into a single application

@TimHess TimHess requested a review from bart-vmware March 8, 2024 22:16
@TimHess TimHess self-assigned this Mar 8, 2024
@TimHess TimHess mentioned this pull request Mar 8, 2024
Merged
5 tasks
@TimHess TimHess changed the base branch from main to latest March 13, 2024 21:32
@TimHess TimHess force-pushed the config branch 3 times, most recently from a21a465 to 51a827a Compare March 13, 2024 23:25
@TimHess TimHess marked this pull request as ready for review March 13, 2024 23:33
@TimHess TimHess force-pushed the config branch 2 times, most recently from 1306e09 to 0f223b3 Compare March 25, 2024 20:25
bart-vmware
bart-vmware requested changes Mar 26, 2024
View reviewed changes
Copy link
Member

@bart-vmware bart-vmware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phew, large PR! I went through all the files, see comments. Nice consolidation.

CommonTasks.md Outdated Show resolved Hide resolved
CommonTasks.md Outdated Show resolved Hide resolved
Configuration/README.md Outdated Show resolved Hide resolved
Configuration/README.md Outdated Show resolved Hide resolved
Configuration/src/Steeltoe.Samples.Configuration/README.md Outdated Show resolved Hide resolved
Configuration/src/Steeltoe.Samples.Configuration/manifest.yml Outdated Show resolved Hide resolved
Configuration/src/Steeltoe.Samples.Configuration/manifest.yml Show resolved Hide resolved
Configuration/src/Steeltoe.Samples.Configuration/wwwroot/css/site.css Outdated Show resolved Hide resolved
Discovery/src/Fortune-Teller-Service/Program.cs Outdated Show resolved Hide resolved
Discovery/src/Fortune-Teller-Service/global.json Outdated Show resolved Hide resolved
@bart-vmware

This comment was marked as outdated.

Sign in to view
@bart-vmware

This comment was marked as resolved.

Sign in to view
bart-vmware
bart-vmware requested changes Mar 27, 2024
View reviewed changes
Copy link
Member

@bart-vmware bart-vmware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates.

ci/templates/setup-tools-steps.yaml Outdated Show resolved Hide resolved
Configuration/src/Steeltoe.Samples.Configuration/Properties/launchSettings.json Outdated Show resolved Hide resolved
Configuration/src/Steeltoe.Samples.Configuration/README.md Outdated Show resolved Hide resolved
Configuration/src/Steeltoe.Samples.Configuration/README.md Outdated Show resolved Hide resolved
Configuration/src/Steeltoe.Samples.Configuration/README.md Outdated Show resolved Hide resolved
Configuration/src/Steeltoe.Samples.Configuration/manifest-windows.yml Show resolved Hide resolved
Configuration/src/Steeltoe.Samples.Configuration/manifest.yml Show resolved Hide resolved
Configuration/src/Steeltoe.Samples.Configuration/wwwroot/css/site.css Outdated Show resolved Hide resolved
Configuration/src/Steeltoe.Samples.Configuration/appsettings.json Outdated Show resolved Hide resolved
.gitattributes Outdated Show resolved Hide resolved
@bart-vmware bart-vmware mentioned this pull request Mar 27, 2024
Merged
@TimHess @bart-vmware
Apply suggestions from code review
bd5a7bf 
Co-authored-by: Bart Koelman <104792814+bart-vmware@users.noreply.github.com>
@TimHess
Copy link
Member Author

TimHess commented Mar 27, 2024

I tried to run a cibuild of a sample. All of the steps succeed, but the build times out after 90 minutes. Do you have any idea what's causing the hang at the end? Are you still working on it?

Was still working on it, should be a lot better now.

@TimHess TimHess requested a review from bart-vmware March 27, 2024 21:11
@bart-vmware bart-vmware mentioned this pull request Mar 28, 2024
Closed
@TimHess TimHess merged commit 13fe516 into latest Mar 28, 2024
7 of 10 checks passed
@TimHess TimHess deleted the config branch March 28, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bart-vmware bart-vmware bart-vmware approved these changes

Assignees

@TimHess TimHess

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TimHess @bart-vmware