Verify response type and fix exception reporting #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no such attribute as `Response.status`. Plus the name of the Response object is `response`, not `r`. http://docs.python-requests.org/en/latest/api/#requests.Response.status_code
Satisfies the case where the server (not the app) does not respond properly. Otherwise we end up parsing something that's probably not JSON and json.loads() throws a very unhelpful ValueError.
SteelPangolin
added a commit
that referenced
this pull request
Jun 20, 2014
Verify response type and fix exception reporting
|
Thanks for the patch! Looks helpful. I'll merge it. |
SteelPangolin
pushed a commit
that referenced
this pull request
Nov 27, 2014
SteelPangolin
pushed a commit
that referenced
this pull request
Nov 27, 2014
Added parallel scan feature.
SteelPangolin
added a commit
that referenced
this pull request
Jan 16, 2015
Verify response type and fix exception reporting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into this problem when trying to do a bulk request for around 750 names. The Apache server responded with a 414 request below, and the exceptions from the
jsonmodule confused me so I thought I would help out the next person that runs into this issue. After all, you gets 2500 requests a day, so this quantity isn't that ridiculous if you don't consider how the sausage is made.