Provide implementations for I/O safety traits unconditionally #244
+17
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(I'll let you rebase then merge when the tests pass) |
These traits have been stabilized with Rust 1.63. Since that is now our MSRV, we can drop the `build.rs` as well as the `autocfg` build dependency. While at it, I've also added a few `use` statements to make the implemenations more readable.
LingMan
force-pushed
the
iosafety
branch
3 times, most recently
from
682f52a to
8e9136e
Compare
|
Ok, slight annoyance with the import paths: |
`std` provides these traits on wasi, so we should probably do so as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit is a cleanup removing the build script. Until now it gated the implementation of
AsFd/AsHandleon the existence of these traits instd. They have been stabilized with Rust 1.63 which will soon be this crate's MSRV.I'll rebase this PR once that has landed. Until then CI will obviously fail.
The second commit enables
AsFd/AsRawFdimplementations on wasi, sincestdprovides the traits there as well.