Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose more fields in DepotManifest #615

Merged
merged 1 commit into from
Dec 17, 2018
Merged

Expose more fields in DepotManifest #615

merged 1 commit into from
Dec 17, 2018

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented Dec 16, 2018

No description provided.

Copy link
Contributor

@JustArchi JustArchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those properties probably should have private set as part of internal API.

@xPaw
Copy link
Member Author

xPaw commented Dec 16, 2018

True that, I just copypasted them from Steam3Manifest.

@codecov-io
Copy link

codecov-io commented Dec 16, 2018

Codecov Report

Merging #615 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #615      +/-   ##
==========================================
+ Coverage   23.59%   23.59%   +<.01%     
==========================================
  Files          85       85              
  Lines        8694     8709      +15     
  Branches      719      719              
==========================================
+ Hits         2051     2055       +4     
- Misses       6511     6523      +12     
+ Partials      132      131       -1
Impacted Files Coverage Δ
SteamKit2/SteamKit2/Types/DepotManifest.cs 0% <0%> (ø) ⬆️
SteamKit2/SteamKit2/Util/DebugLog.cs 67.18% <0%> (+6.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a12aad9...5ce2929. Read the comment docs.

Copy link
Contributor

@JustArchi JustArchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@azuisleet azuisleet merged commit df0d048 into SteamRE:master Dec 17, 2018
@xPaw xPaw deleted the xpaw/depot-manifests branch June 18, 2020 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants