NHA2: Decode CS2 store data #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for LZMA-decoded Binary KV to NHA2 Adds support for 0x0B (AlternateEnd) to KeyValue
xPaw
reviewed
Sep 30, 2024
SteamKit2/SteamKit2/Util/LzmaUtil.cs
Outdated
| /// <summary> | ||
| /// Internal helper to decode data blobs with the 'LZMA' magic header. | ||
| /// </summary> | ||
| public static class LzmaUtil |
There was a problem hiding this comment.
I would avoid exposing this publicly.
There was a problem hiding this comment.
I'd need InternalsVisibleTo for NHA2 then, or to move the whole thing into NHA2.
If GC are using it at the protocol level somehow then it would be needed by SK2 clients.
If they're not and its game-specific then I'd be on the fence about including it.
There was a problem hiding this comment.
Then I need a second copy of the LZMA SDK to get at the Decoder. 😞
There was a problem hiding this comment.
That's annoying. InternalsVisibleTo then? :(
There was a problem hiding this comment.
yeah, seems like the least evil option for now
xPaw
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs tests but PR is up for people to build themselves or use GHA artefacts.
Addresses the issue described in discussion #1440.
The payload is a binary blob with the four-byte magic
LZMA. This doe not seem to be a standard but is possibly a Valve creation, as seen elsewhere in ValveResourceFormat.It also uses a different type of KeyValues binary serialisation, using
AlternateEndfrom VBKV as seen here: ValveResourceFormat/ValveKeyValue#9These changes probably need some new tests for the modified KV logic, and ideally also for the new LzmaUtil class.