Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CDN client #1022

Merged
merged 6 commits into from
Nov 14, 2021
Merged

Refactor CDN client #1022

merged 6 commits into from
Nov 14, 2021

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented Sep 25, 2021 •
edited
Loading

  • Moved it to CDN namespace, with classes being split.
  • Removed AuthenticateDepot and CDN auth tokens
  • Added GetServersForSteamPipe which goes over CM instead of WebAPI
  • Added support for manifest request codes:
    Is SteamContent a good name for this? There's other methods I'd like to implement from it later:

    SteamKit/SteamKit2/SteamKit2/Base/Generated/SteamMsgContentSystem.cs

    Lines 465 to 466 in b5d8502

    CContentServerDirectory_GetServersForSteamPipe_Response GetServersForSteamPipe(CContentServerDirectory_GetServersForSteamPipe_Request request);
    CContentServerDirectory_GetDepotPatchInfo_Response GetDepotPatchInfo(CContentServerDirectory_GetDepotPatchInfo_Request request);

I made the function async, because AsyncJob can't deal with unified messages nicely as they get routed to SteamUnifiedMessages. Perhaps (in future) it could be expanded so it would support unified messages natively for proper callback handling?

yaakov-h
yaakov-h reviewed Sep 25, 2021
View reviewed changes
Copy link
Member

@yaakov-h yaakov-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is a manifest request code, what does it actually mean/do?

@xPaw xPaw changed the title Add support for manifest request codes Refactor CDN client Oct 6, 2021
@yaakov-h yaakov-h requested a review from azuisleet October 7, 2021 11:00
@xPaw xPaw marked this pull request as ready for review October 11, 2021 07:53
@yaakov-h yaakov-h mentioned this pull request Nov 13, 2021
Closed
13 tasks
@azuisleet
Copy link
Member

Release note: breaking changes

yaakov-h
yaakov-h reviewed Nov 14, 2021
View reviewed changes
@yaakov-h yaakov-h added this to the 2.4.0 milestone Nov 14, 2021
@yaakov-h yaakov-h merged commit e58b8d4 into SteamRE:master Nov 14, 2021
@xPaw xPaw deleted the manifestcode branch November 14, 2021 11:57
@xPaw xPaw mentioned this pull request Jul 25, 2024
Closed
xPaw added a commit that referenced this pull request Aug 25, 2024
@xPaw
Bring back support for CDN auth tokens
9ed08d4 
Needed for some Chinese servers.

It was removed in #1022.

Fixes  #1372.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaakov-h yaakov-h yaakov-h left review comments

@azuisleet azuisleet azuisleet approved these changes

Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@xPaw @azuisleet @yaakov-h