Ignore check for explicit assignment of optional fields #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Oct 8, 2022
tomasbasham
commented
Oct 10, 2022
tomasbasham
force-pushed
the
ignore-check-for-explicit-assignment
branch
from
3e1a736 to
4b07827
Compare
Some optional fields with default values were not being persisted correctly when a resource was created. This was due to how Terraform and Go handles zero-values for specific data types. This commit ensures that these fields are always sent to the API despite their value having been changed since the last application of the Terraform configuration. This prevents having to check whether an optional value has been explicitly set, or has been given the default (often zero-value) value.
tomasbasham
force-pushed
the
ignore-check-for-explicit-assignment
branch
from
4b07827 to
3751e9a
Compare
57656E6474
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some optional fields with default values were not being persisted correctly when a resource was created. This was due to how Terraform and Go handles zero-values for specific data types.
This commit ensures that these fields are always sent to the API despite their value having been changed since the last application of the Terraform configuration. This prevents having to check whether an optional value has been explicitly set, or has been given the default (often zero-value) value.