Allow the uptime check address field to be more permissive #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasbasham
commented
Aug 9, 2022
| Description: "URL or IP address of the server under test", | ||
| ValidateFunc: validation.Any(validation.IsURLWithHTTPorHTTPS, validation.IsIPAddress), | ||
| Description: "URL, FQDN, or IP address of the server under test", | ||
| ValidateFunc: validation.StringIsNotEmpty, |
There was a problem hiding this comment.
The API itself will go most of the way to validate this value anyway
57656E6474
approved these changes
Aug 9, 2022
At present the uptime check address field will only accept values that begin with an HTTP scheme or are valid IP addresses. This prevents certain values from being used that would make more sense for particular test types - for example ICMP, and TCP. This commit removes the validation from the address field entirely as otherwise the variation of values would make the field too difficult to validate.
tomasbasham
force-pushed
the
remove-validation-from-uptime-address-field
branch
from
077a01e to
a600ab8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present the uptime check address field will only accept values that
begin with an HTTP scheme or are valid IP addresses. This prevents
certain values from being used that would make more sense for particular
test types - for example ICMP, and TCP.
This commit removes the validation from the address field entirely as
otherwise the variation of values would make the field too difficult to
validate.