Skip to content

Commit

Permalink
Pin and fix katib images. (kubeflow#1113)
Browse files Browse the repository at this point in the history
* The latest images are too old; we should be using the images with tag "master"

* For the 0.2 release we want to pin the images to specific images which
  we tag 0.2.0

* Delete the protoype parameter katibImagTag; image parameters should provide
  the full image reference including the tag. This makes it much easier
  to override certain images and is consistent with other components.

* Create a simple, oneoff script to retag the existing Katib images into
  the Kubeflow image repository

  * We most likely won't ever use this again but its good to leave a paper
    trail.

Related to:
  kubeflow/katib#133 Katib images in 0.2.0-rc.1 are too old
     * Will need to cherry pick this.

  Fix kubeflow/katib#132 Get rid of katibImageTag

  Fix kubeflow/katib#131 Katib prototype needs to pin docker images
  • Loading branch information
jlewi authored and k8s-ci-robot committed Jul 2, 2018
1 parent a58741f commit a6ffe7a
Show file tree
Hide file tree
Showing 5 changed files with 48 additions and 10 deletions.
39 changes: 39 additions & 0 deletions hack/retag_katib_images.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
#!/bin/bash
#
# One off script to retag Katib images for 0.2
set -ex
docker pull mitdbg/modeldb-backend:latest
docker pull katib/katib-frontend:master
docker pull katib/suggestion-random:master
docker pull katib/suggestion-grid:master
docker pull katib/vizier-core:master

docker tag mitdbg/modeldb-backend:latest \
gcr.io/kubeflow-images-public/modeldb-backend:v0.2.0

docker tag katib/katib-frontend:master \
gcr.io/kubeflow-images-public/katib-frontend:v0.2.0

docker tag katib/suggestion-random:master \
gcr.io/kubeflow-images-public/katib-suggestion-random:v0.2.0

docker tag katib/suggestion-grid:master \
gcr.io/kubeflow-images-public/katib-suggestion-grid:v0.2.0

docker tag katib/vizier-core:master \
gcr.io/kubeflow-images-public/katib-vizier-core:v0.2.0

gcloud docker -- push \
gcr.io/kubeflow-images-public/modeldb-backend:v0.2.0

gcloud docker -- push \
gcr.io/kubeflow-images-public/katib-frontend:v0.2.0

gcloud docker -- push \
gcr.io/kubeflow-images-public/katib-suggestion-random:v0.2.0

gcloud docker -- push \
gcr.io/kubeflow-images-public/katib-suggestion-grid:v0.2.0

gcloud docker -- push \
gcr.io/kubeflow-images-public/katib-vizier-core:v0.2.0
2 changes: 1 addition & 1 deletion kubeflow/katib/modeldb.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@
value: "/katib",
},
],
image: params.modeldbFrontendImage + ":" + params.katibImageTag,
image: params.modeldbFrontendImage,
imagePullPolicy: "IfNotPresent",
name: "modeldb-frontend",
ports: [
Expand Down
11 changes: 5 additions & 6 deletions kubeflow/katib/prototypes/all.jsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,12 @@
// @description Kubeflow hyperparameter tuning component
// @shortDescription hp-tuning
// @param name string Name to give to each of the components
// @optionalParam katibImageTag string latest Image tag for katib images
// @optionalParam modeldbImage string mitdbg/modeldb-backend:latest The image for modeldb
// @optionalParam modeldbImage string gcr.io/kubeflow-images-public/modeldb-backend:v0.2.0 The image for modeldb
// @optionalParam modeldbDatabaseImage string mongo:3.4 The image for modeldb database.
// @optionalParam modeldbFrontendImage string katib/katib-frontend The image for modeldb frontend.
// @optionalParam suggestionRandomImage string katib/suggestion-random The image for random suggestion.
// @optionalParam suggestionGridImage string katib/suggestion-grid The image for grid suggestion.
// @optionalParam vizierCoreImage string katib/vizier-core The image for vizier core.
// @optionalParam modeldbFrontendImage string gcr.io/kubeflow-images-public/katib-frontend:v0.2.0 The image for modeldb frontend.
// @optionalParam suggestionRandomImage string gcr.io/kubeflow-images-public/katib-suggestion-random:v0.2.0 The image for random suggestion.
// @optionalParam suggestionGridImage string gcr.io/kubeflow-images-public/katib-suggestion-grid:v0.2.0 The image for grid suggestion.
// @optionalParam vizierCoreImage string gcr.io/kubeflow-images-public/katib-vizier-core:v0.2.0 The image for vizier core.
// @optionalParam vizierDbImage string mysql:8.0.3 The image for vizier db.

local k = import "k.libsonnet";
Expand Down
4 changes: 2 additions & 2 deletions kubeflow/katib/suggestion.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
spec: {
containers: [
{
image: params.suggestionRandomImage + ":" + params.katibImageTag,
image: params.suggestionRandomImage,
name: "vizier-suggestion-random",
ports: [
{
Expand Down Expand Up @@ -125,7 +125,7 @@
spec: {
containers: [
{
image: params.suggestionGridImage + ":" + params.katibImageTag,
image: params.suggestionGridImage,
name: "vizier-suggestion-grid",
ports: [
{
Expand Down
2 changes: 1 addition & 1 deletion kubeflow/katib/vizier.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
"-i",
"k-cluster.example.net",
],
image: params.vizierCoreImage + ":" + params.katibImageTag,
image: params.vizierCoreImage,
name: "vizier-core",
ports: [
{
Expand Down

0 comments on commit a6ffe7a

Please sign in to comment.