Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mc): upgrade version #334

Merged
merged 2 commits into from
Mar 29, 2022
Merged

fix(mc): upgrade version #334

merged 2 commits into from
Mar 29, 2022

Conversation

jumana-s
Copy link
Contributor

@jumana-s jumana-s commented Mar 25, 2022

Description

What your PR adds/fixes/removes

Closes #333

Tests / Quality Checks

Automated Testing/build and deployment

  • Does the image pass CI successfully (build, pass vulnerability scan, and pass automated test suite)?
  • If new features are added (new image, new binary, etc), have new automated tests been added to cover these?
  • If new features are added that require in-cluster testing (e.g. a new feature that needs to interact with kubernetes), have you added the auto-deploy tag to the PR before pushing in order to build and push the image to ACR so you can test it in cluster as a custom image?

JupyterLab extensions

  • Are all extensions "enabled" (jupyter labextension list from inside the notebook)?

VS Code tests

  • Does VS Code open?
  • Can you install extensions?

Code review

  • Have you added the auto-deploy tag to your PR before your most recent push to this repo? This causes CI to build the image and push to our ACR, letting reviewers access the built image without having to create it themselves
  • Have you chosen a reviewer, attached them as a reviewer to this PR, and messaged them with the SHA-pinned image name for the final image to test (e.g. k8scc01covidacr.azurecr.io/machine-learning-notebook-cpu:746d058e2f37e004da5ca483d121bfb9e0545f2b)?

@jumana-s jumana-s added the auto-deploy Trigger manual CI steps for this PR label Mar 25, 2022
@Jose-Matsuda Jose-Matsuda self-requested a review March 28, 2022 20:08
Copy link
Contributor

@Jose-Matsuda Jose-Matsuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM was able to do on both dev and prod basic commands like mc alias , mc ls, mc cp mc mv mc rm mc mirror seemed to work without a hitch. (used image tag 78a9b939 as thats what I saw in the ci as I was getting issues using a63a6fb

@jumana-s jumana-s merged commit aef1fdf into master Mar 29, 2022
@Jose-Matsuda Jose-Matsuda deleted the upgrade-mc branch March 31, 2022 13:47
@Jose-Matsuda Jose-Matsuda mentioned this pull request Apr 22, 2022
11 tasks
JaeggerJose pushed a commit to wycc/cgu-kubeflow-containers that referenced this pull request Dec 30, 2024
* fix(mc): upgrade to latest

* fix: use https instead of git
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-deploy Trigger manual CI steps for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade mc
2 participants