Skip to content

Commit

Permalink
fix: booleans are actually all strings
Browse files Browse the repository at this point in the history
kill me 😗
actions/runner#1483
  • Loading branch information
EveningStarlight committed Dec 4, 2024
1 parent 8c03cda commit 7e1bc27
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/docker-steps.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ on:
parent-image-is-diff:
description: Parent image has been changed?
required: false
type: boolean
default: false
type: string
default: "false"
base-image:
description: The base image to build from if not located on our own repo
required: false
Expand Down Expand Up @@ -44,7 +44,7 @@ jobs:

build-upload:
needs: [check-diff]
if: ${{ needs.check-diff.outputs.is-diff || inputs.parent-image-is-diff }}
if: ${{ needs.check-diff.outputs.is-diff || inputs.parent-image-is-diff == "true" }}
uses: ./.github/workflows/docker-build-upload.yaml
with:
parent-image: ${{ inputs.parent-image }}
Expand All @@ -57,7 +57,7 @@ jobs:

pull-upload:
needs: [check-diff]
if: ${{ !needs.check-diff.outputs.is-diff && !inputs.parent-image-is-diff }}
if: ${{ !needs.check-diff.outputs.is-diff && inputs.parent-image-is-diff == "false" }}
uses: ./.github/workflows/docker-pull-upload.yaml
with:
image: ${{ inputs.image }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/docker.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
with:
image: "base-kubeflow"
parent-image: "base-cpu"
parent-image-is-diff: ${{ needs.base-cpu.outputs.is-diff }}
parent-image-is-diff: "${{ needs.base-cpu.outputs.is-diff }}"
registry-name: "${{ needs.vars.outputs.DEV_REGISTRY_NAME }}"
secrets:
REGISTRY_USERNAME: ${{ secrets.DEV_REGISTRY_USERNAME }}
Expand Down

0 comments on commit 7e1bc27

Please sign in to comment.